Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol for decimal number #2

Open
CBenghi opened this issue Apr 28, 2023 · 4 comments
Open

Symbol for decimal number #2

CBenghi opened this issue Apr 28, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request OnHold This issue is postponed waiting on some other task.
Milestone

Comments

@CBenghi
Copy link
Collaborator

CBenghi commented Apr 28, 2023

Note: moved here from https://github.com/CBenghi/ids-tool/issues/2, initially submitted by @cicciopage

According to XSD, decimal number must have dot (.) symbol to separate the whole number from its fractional parts.
If the symbol is comma , as it's used in some locales, the tool must return an error.

Example:
Correct:

12.3 
45.45 
67.444

Error:

12,3 
45,45 
67,444
@CBenghi
Copy link
Collaborator Author

CBenghi commented Apr 28, 2023

Thanks @cicciopage,

this makes sense, but I wonder how we can implement it.

Commas are not inherently a problem. This would probably apply to the value of properties that

  • have an IFC measure, or
  • are one of the default properties with predefined numeric type.

Can you think of other scenarios?

@CBenghi CBenghi added this to the Version 1.1 milestone Apr 28, 2023
@CBenghi CBenghi added the enhancement New feature or request label Apr 28, 2023
@cicciopage
Copy link

Yes, I speak about values inside the restrictions, where we have also the type (xs:decimal).

@CBenghi
Copy link
Collaborator Author

CBenghi commented May 8, 2023

Yes, I speak about values inside the restrictions, where we have also the type (xs:decimal).

This makes total sense. I'll implement it.

@CBenghi CBenghi self-assigned this Oct 7, 2023
@CBenghi
Copy link
Collaborator Author

CBenghi commented Oct 7, 2023

This is also on hold as we define what to do with regards to the xs restriction types (they might be redundant).

@CBenghi CBenghi added the OnHold This issue is postponed waiting on some other task. label Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request OnHold This issue is postponed waiting on some other task.
Projects
None yet
Development

No branches or pull requests

2 participants