Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nested includes #722

Open
yosefy opened this issue Nov 22, 2023 · 4 comments
Open

nested includes #722

yosefy opened this issue Nov 22, 2023 · 4 comments
Labels

Comments

@yosefy
Copy link

yosefy commented Nov 22, 2023

hi, any chance we can make it possible
missing this feature so much

meaning in included config, there will be another include which depends on values from parent include

thanks

@ashitr
Copy link

ashitr commented Nov 23, 2023

This would help, allowing to ask further inputs based on previous inputs provided.

@yosefy
Copy link
Author

yosefy commented Nov 23, 2023 via email

@bugy
Copy link
Owner

bugy commented Nov 27, 2023

Hi, @yosefy could you describe your use case a little bit more detailed? As for me, "depends on" and "include" have slightly different usages:

  • "include" should be used for "reusable" configurations, i.e. when multiple scripts use the same configuration
  • "depends on" should be used for dynamic visibility of parameters

I guess the main confusion here, is that script server allows "dynamic include", which is probably has nothing to do with reusability. And actually, in many cases, it causes duplicity, because people have to introduce several "included" files for different parameter values.
I think, my preferred solution here would be to add something like enabled option for each parameter, which will call some script and depending on the script results, might include the parameter.
It should be more flexible than depends on, since it will allow to enable a parameter for certain values and even depend on some other conditions (e.g. time of a day 😅)

What do you think?

@bugy bugy added the feature label Nov 27, 2023
@yosefy
Copy link
Author

yosefy commented Nov 27, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants