Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix addGridLayout bug when this plugin is combined with addHiddenColumns plugin #180

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stephane-klein
Copy link

Hi @bryanmylee , here is the path to fix #179 bug.

Best regards,
Stéphane

@bryanmylee
Copy link
Owner

Hey @stephane-klein, I'm really sorry this took so long.

Unfortunately, I don't think this is the approach that we should be using to solve the issue. With this fix, addGridLayout will always override the table's style without allowing other plugins to intercept or modify the attrs.

Maybe we should use the cell's colspan and colstart prop to determine the position, then add a hook to addHiddenColumns to change the colstart and colspan prop before addGridLayout?

@stephane-klein
Copy link
Author

Unfortunately, I don't think this is the approach that we should be using to solve the issue. With this fix, addGridLayout will always override the table's style without allowing other plugins to intercept or modify the attrs.

Ok, I understand.

Maybe we should use the cell's colspan and colstart prop to determine the position, then add a hook to addHiddenColumns to change the colstart and colspan prop before addGridLayout?

I'll try to take the time to come up with a new patch in the next ten days.

@stephane-klein stephane-klein changed the title Fix addGridLayout bug when this plugin is combined with addHiddenColumns plugin #179 Fix addGridLayout bug when this plugin is combined with addHiddenColumns plugin Jan 2, 2024
@bryanmylee bryanmylee marked this pull request as draft January 16, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants