Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding charges to NEP #299

Open
brucefan1983 opened this issue Nov 7, 2022 · 3 comments
Open

adding charges to NEP #299

brucefan1983 opened this issue Nov 7, 2022 · 3 comments
Assignees

Comments

@brucefan1983
Copy link
Owner

Many users hope to have this feature.

How to set up the charges:

  • Fixed charges?
    • let the user to specify?
    • let SNES to optimize?
  • Dynamic charges?
    • a separate NN is needed
    • need to study the literature

How to evaluate the interactions from the charges?

  • the simple DSF method (damped shifted force); I like this
  • the canonical Ewald summation; the golden standard
@ZKC19940412
Copy link

ZKC19940412 commented Nov 8, 2022

Hi, it is definitely a major step ahead to include charges. Here is a review from the HDNNP by Professor Jörg Behler (https://pubs.acs.org/doi/abs/10.1021/acs.chemrev.0c00868) and page 15 - 20 goes over their latest scheme of incorporating charges and might be useful for brainstorm the charge implementations for NEP. Just want to add a comment that while adding this new features, might be useful to do benchmarking on efficiency too? I love NEP because it is always the best in terms of balancing efficiency and accuracy. I would love to see NEP is always the fastest code for large scale MD simulations.

@brucefan1983
Copy link
Owner Author

Thanks for the comments. This review is very helpful! I also hope to keep the superior speed of NEP, so I was thinking a non-Ewald way to evaluate the Coulomb forces.

@brucefan1983
Copy link
Owner Author

Aim to achieve this within GPUMD-v4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants