Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WYSIWG Needs to include full path of filename when uploaded in KCFinder #2

Open
lonnieezell opened this issue Jun 25, 2013 · 3 comments
Labels

Comments

@lonnieezell
Copy link
Contributor

No description provided.

@brockf
Copy link
Owner

brockf commented Jun 25, 2013

What is it including now? It should, now, be including the path RELATIVE to the root of the Hero site. This, in tandem with a <base href="{url}" /> tag in the layout.thtml template, should keep the image src links in tact.

@lonnieezell
Copy link
Contributor Author

From what I recall, we had 2 or 3 people running into issues where the images would be display on the front end just fine, but would show as broken in the admin area. This was due to lacking the '/' at the beginning of the relative url it was given, so it was trying to pull it relative to the current page, which was incorrect. If we could get a full path returned, instead of a relative path, it would fix this.

@brockf
Copy link
Owner

brockf commented Jun 25, 2013

Yes but then it would break on the frontend AND it would make the site break everytime it was moved from one directory to another.

The solution is having it RELATIVE to the current directory but, yes, this needs to work for both the admin panel and the frontend.

Some simple testing should show whether this is the case or not. It used to be, that I know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants