Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitle support #115

Open
bogab opened this issue Feb 21, 2016 · 15 comments
Open

Subtitle support #115

bogab opened this issue Feb 21, 2016 · 15 comments

Comments

@bogab
Copy link

bogab commented Feb 21, 2016

Hi @brianwernick ,
Do you support srt subtitle rendering?

@brianwernick
Copy link
Owner

Not currently, though this is something that should probably be slated for the 3.x track

@bogab
Copy link
Author

bogab commented Feb 22, 2016

Any time frame when this will be released?

@brianwernick
Copy link
Owner

Sadly no. I've been pretty busy with work lately and since this will be after the 3.0 release I can't say for certain.

@brianwernick
Copy link
Owner

An initial implementation has been added in https://github.com/brianwernick/ExoMedia/tree/issue-115_subtitle_callbacks however I would like to to 2 things before it is merged:

  1. Abstract the listener away from the ExoPlayer implementation of Cue
  2. Add support for TimedTextListener for the MediaPlayer instances (only for API 16+)

Adding something like subtitle support is quite a large task but I hope to get it implemented (at least with a basic level) for the 3.1 release

@mirjafarabedi
Copy link

Hi Brian.
Do you support subtitle in 3.0.5 release ?

@brianwernick brianwernick modified the milestones: 3.2.0, 3.1.0 Nov 6, 2016
@ntsik
Copy link

ntsik commented Mar 13, 2017

Any news on this? Would love to have this functionality.

@brianwernick
Copy link
Owner

I haven't had time to work on ExoMedia much lately so this will most likely be in a post 4.0 release

@jboisjo
Copy link

jboisjo commented Mar 31, 2017

can't wait!! i'd love to have it too :)

@brianwernick brianwernick modified the milestones: 4.1.0, 3.2.0 Mar 31, 2017
@billyjoker
Copy link

I'm testing with a HLS with integrated subtitles, firstly i did not get any callback onCues, but currently i'm able to get text from the onCues implementation (the listeners are all right ☺). What i've got to do the trick is at the constructor of EmExoplayer, by modifyng as follows:

player.setSelectedTrack(RENDER_TIMED_METADATA, RENDER_TIMED_METADATA);

I'd like more info about the way to get the subtitle track of a available language to keep developing on it. Thanks for this branch!!

@jboisjo
Copy link

jboisjo commented Jul 10, 2017

Any news on that Brian ? :)

Thank you!!

@juliafu1
Copy link

@brianwernick does the video support closed caption/subtitle now?

@brianwernick brianwernick added this to To do in Version 5.0 Aug 10, 2018
@vannestf
Copy link

Do you have news of subtitle support srt / closed caption?
The work you are doing is fantastic.

@brianwernick
Copy link
Owner

Sadly I have no additional news on the progress of sub/cc (or 5.0 in general) :(

@netomx
Copy link

netomx commented Aug 30, 2018

Is there a chance that we can donate for this request to have priority?

Thanks!

@hansenji
Copy link
Contributor

There is now a sample in the demo app on how to get closed captions for video playback.
See Commit c0f4bc3

@brianwernick brianwernick removed this from the 5.0.0 milestone Jul 12, 2022
@brianwernick brianwernick added this to the 5.1.0 milestone Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To do
Version 5.0
  
To do
Development

No branches or pull requests

10 participants