Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show loading while buffering #102

Open
hadifar opened this issue Feb 11, 2016 · 13 comments
Open

Show loading while buffering #102

hadifar opened this issue Feb 11, 2016 · 13 comments
Projects
Milestone

Comments

@hadifar
Copy link

hadifar commented Feb 11, 2016

In your next release you can consider this it would be nice in low-internet speed connections.

@brianwernick
Copy link
Owner

I'm glad you brought this up, I'll try to get it in to the 3.0 release

@hadifar hadifar closed this as completed Feb 11, 2016
@hadifar hadifar reopened this Mar 31, 2016
@brianwernick brianwernick added this to the 3.x milestone Mar 31, 2016
@brianwernick
Copy link
Owner

@aarongrider, The ExoPlayer doesn't inform us of Buffering updates which is why the OnBufferingUpdateListener is not called, nor is it related because this is a feature request not a bug report

@kashifandroiddev
Copy link

does 3.0 preview have this feature of show buffring while loading i want to test it ?

@brianwernick
Copy link
Owner

@kashifandroiddev no, this hasn't been added yet (otherwise the request would have been closed)

@appyo
Copy link

appyo commented Jun 22, 2016

You can add new ExoPlayerListener to your Videoview and in onStateChanged it fires "Exoplayer.STATE_BUFFERING" as playbackstate when it's buffering. I tested with exomedia 2.5.6 and it works.

@brianwernick
Copy link
Owner

@appyo While you can register that listener it doesn't provide quite the functionality this addresses. The STATE_BUFFERING represents a fairly short cache of the video, on slow internet connections this may only be a second or so, which will play then hit the buffering again. Ideally we would monitor the network speed and determine a minimum amount (or allow it to be specified) that we need buffered before we automatically resume playback.

What you mentioned is already used (in 3.0) to represent loading when seeking and initial load

@appyo
Copy link

appyo commented Jun 22, 2016

Thanks @brianwernick for your information. I did not know that and i use this only for showing progressbar or similar to inform the user that the video freezes briefly and he does not think that the player has crashed or so. You are right of course it is better if you could adjust the buffering to the network speed. I will test the 3.0 soon, many thanks for your great work.

@miladz68
Copy link

this feature is a great. I had implemented this in 2.5.6 by adding an exoplayerlistener which is not available in version 3.0.0

@vishnuganta22
Copy link

vishnuganta22 commented Aug 18, 2016

how can i know that video is buffering in version 3.0.1.Can you add a callback when video starts and ends buffering .

@IOException722
Copy link

IOException722 commented Jun 22, 2018

hey @brianwernick

Thanks for the great library.

The issue is still opened for 2 years. Should we wait for the issue to be fixed or try different options?

Do let me know as we are moving into production.
Thanks

@brianwernick
Copy link
Owner

I'm still planning on adding the functionality; it's actually one of the main tasks for the 5.0 release. However I don't know how soon I'll be able to get to it (I'm hoping in the next month)

@deebash
Copy link

deebash commented Jun 17, 2019

Have you added that feature?

@brianwernick brianwernick removed this from the 5.0.0 milestone Sep 22, 2022
@brianwernick brianwernick added this to the 5.1.0 milestone Sep 22, 2022
@brianwernick
Copy link
Owner

There are two parts to this request:

  1. Improving the existing functionality to show loading while buffering when playback catches up to the buffer.
  2. Adding the capabilities to track the buffer / download speed and dynamically adjust the playback resumption.

With the work that we have already done in 5.0 to improve state communication has addressed part 1 above. Because part 1 seems to be the more important part of the request for most I'm going to move part 2 to a future release so that we can get the 5.0 release out sooner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To do
Version 5.0
  
To do
Development

No branches or pull requests

8 participants