Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor constant UI strings #4

Open
ericyanush opened this issue Feb 26, 2015 · 2 comments
Open

Refactor constant UI strings #4

ericyanush opened this issue Feb 26, 2015 · 2 comments
Assignees
@ericyanush
Labels
awaiting testing enhancement in progress
Milestone
2.8

Comments

@ericyanush
Copy link

Move constant UI strings from literals to singular constants. Many of the UI string literals currently used are used in more than one place. They are both difficult to change, and result in duplicate instances in progmem. Doing this would allow translations to be done down the road.
@ericyanush ericyanush self-assigned this Feb 26, 2015
@ericyanush ericyanush added this to the 2.8 milestone Feb 26, 2015
@ericyanush
Copy link
Author

Along side refactoring the strings out of the code, the strings should be namespaced so that it is clearer where each string is being used.

@ericyanush
Copy link
Author

Work on this issue should be completed as of e5a9346, pending any issued found in testing.

@ericyanush ericyanush mentioned this issue Jul 31, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericyanush ericyanush

Labels
awaiting testing enhancement in progress
Projects
None yet
Milestone
2.8
Development

No branches or pull requests
1 participant
@ericyanush