Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request for different Euler angle conventions #16

Open
mjo22 opened this issue Jan 9, 2024 · 2 comments
Open

Feature request for different Euler angle conventions #16

mjo22 opened this issue Jan 9, 2024 · 2 comments

Comments

@mjo22
Copy link

mjo22 commented Jan 9, 2024

Hello! I would like to make a feature request for converting and instantiating SO3 objects to and from different euler angle conventions.

This proposal could replace SO3.from_rpy_radians with SO3.from_euler_radians, and similarly for SO3.as_rpy_radians. This new method could have a “convention” optional argument, which specifies the sequence of rotations. It could follow from the from_euler and as_euler methods here: https://jax.readthedocs.io/en/latest/_autosummary/jax.scipy.spatial.transform.Rotation.html

@brentyi
Copy link
Owner

brentyi commented Jan 9, 2024

This makes sense to me!

Do you have time for a PR? I can also take a stab at it at some point if you don't, it might just take a little while.

@mjo22
Copy link
Author

mjo22 commented Jan 10, 2024

I won’t be able to get to it for a little while as well. Will try to take a stab at it sometime this month! If you want to give it a shot before I get to it, that would be awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants