Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News' "add this RSS feed" functionality doesn't honor the HTTPS upgrade setting #38282

Open
fmarier opened this issue May 13, 2024 · 3 comments

Comments

@fmarier
Copy link
Member

fmarier commented May 13, 2024

Steps To Reproduce:

  1. Enable Brave News
  2. In Brave settings (brave://settings/shields), set "Upgrade connections to HTTPS" to "Strict"
  3. Open WireShark. Enable capturing. Set the display filter in WireShark to http
  4. Visit https://fmarier.github.io/brave-testing/news-add-rss.html
  5. Click the feed icon in the URL bar
  6. Go back to WireShark. You can see a plaintext request sent to 172.105.6.87

Actual

Screenshot from 2024-05-13 10-52-56

Expected

The request should be upgraded to HTTPS and no HTTP request should be visible in WireShark.

Originally reported at https://hackerone.com/reports/2502007

@fmarier
Copy link
Member Author

fmarier commented May 13, 2024

The other thing that this suggests is that we are likely not running these URLs through our privacy filters (e.g. debouncer, query string filter).

@fmarier
Copy link
Member Author

fmarier commented May 13, 2024

To confirm, I updated the test page to add an fbclid parameter to the URL and it doesn't get stripped out:
Screenshot from 2024-05-13 12-15-18

@bsclifton
Copy link
Member

cc: @LorenzoMinto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants