Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[perf] Unlocking Wallet hangs UI thread #38280

Open
atuchin-m opened this issue May 13, 2024 · 4 comments
Open

[perf] Unlocking Wallet hangs UI thread #38280

atuchin-m opened this issue May 13, 2024 · 4 comments
Assignees
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality perf

Comments

@atuchin-m
Copy link
Contributor

atuchin-m commented May 13, 2024

Description

Some Wallet UI task blocks UI thread for a long time during unlocking.

Steps to Reproduce

  1. Create a Wallet if you don't have one;
  2. Start recording chrome://tracing
  3. Open brave://wallet and unlock;
  4. Stop recording, check BrowserMain thread

Actual result:

A long UI task takes 254ms on MPB M1 pro.
On a low end android phone it probably takes a few seconds.
UI_hang_unlocking_wallet

Expected result:

No long UI tasks that blocks UI

Reproduces how often:

always

Desktop Brave version:

1.68.2 Chromium: 125.0.6422.41 (Official Build) nightly (arm64)

@atuchin-m atuchin-m added perf feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop labels May 13, 2024
@atuchin-m
Copy link
Contributor Author

  1. Unlocking a wallet could be a relatively usual user action (comparing to creating a new wallet).
  2. 250ms is a really long time for M1 pro. For Android we probably have some ANRs because of that.

@atuchin-m
Copy link
Contributor Author

cc @bbondy @supermassive

@supermassive
Copy link

@supermassive
Copy link

This brave/brave-core#23363 should make unlocking 8-10 times faster, but still blocking.
Will fix

@supermassive supermassive self-assigned this May 14, 2024
@supermassive supermassive added the OS/iOS Fixes related to iOS browser functionality label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality perf
Projects
None yet
Development

No branches or pull requests

2 participants