Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ads] Fixes same document navigations should trigger NotifyTab[Text/Html]ContentDidChange after tab switch #23616

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aseren
Copy link
Collaborator

@aseren aseren commented May 13, 2024

Resolves brave/brave-browser#38276

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Fresh Install
  2. Join Brave Rewards
  3. Visit Single Page Application webpage
  4. Open new tab with another webpage
  5. Switch back to a tab with Single Page Application webpage
  6. Do a same document navigation within SPA webpage

EXPECTATION:
Same document navigation within SPA webpage trigger NotifyTab[Text/Html]ContentDidChange.
There should the following log lines:

  • Tab id 1130919985 HTML content changed
  • Tab id 1130919985 text content changed

@aseren aseren requested a review from a team as a code owner May 13, 2024 19:32
@aseren aseren requested a review from tmancey May 13, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants