Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable conflict resolution in auto-generated uplifts #38260

Open
wknapik opened this issue May 13, 2024 · 1 comment
Open

Enable conflict resolution in auto-generated uplifts #38260

wknapik opened this issue May 13, 2024 · 1 comment

Comments

@wknapik
Copy link
Contributor

wknapik commented May 13, 2024

Currently, if there are conflicts, script/uplift.py will just fail, forcing the developer to perform the entire uplift process manually.

I see 480 hits for [ERROR] cherry-pick failed for branch in the uplift channel.

We could improve this by doing everything that can be done automatically and then letting the developer resolve the conflicts.

This could be done by opening the code in some web IDE and letting the uplift requester resolve the conflicts there and create the uplift PR including the resolutions.

Another, simpler option would be to just commit the files including unresolved conflicts, create the PR(s) with a label indicating that the conflicts are there and CI shouldn't run, and let the developer check the branch out locally, resolve conflicts and push. The fix could be easily detected to remove the label via a GitHub action.

cc @bsclifton

@wknapik
Copy link
Contributor Author

wknapik commented May 13, 2024

Related #38259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
CI concerns
  
Backlog
Development

No branches or pull requests

1 participant