Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't disable secure DNS #38258

Closed
atuchin-m opened this issue May 13, 2024 · 5 comments · Fixed by brave/brave-core#23660
Closed

Can't disable secure DNS #38258

atuchin-m opened this issue May 13, 2024 · 5 comments · Fixed by brave/brave-core#23660
Assignees
@arthuredelstein
Labels
bug feature/settings OS/Desktop QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.66.x - Release

Comments

@atuchin-m
Copy link
Contributor

Description

Can't disable secure DNS via brave://settings

Steps to Reproduce

  1. open brave://settings/security?search=dns
  2. disable Use secure DNS
  3. reload the page

Actual result:

Use secure DNS checkbox is enabled.

Expected result:

Use secure DNS checkbox is disabled. Secure DNS doesn't work.

Reproduces how often:

Easily

Brave version (brave://version info)

1.68.2 Chromium: 125.0.6422.41 (Official Build) nightly (arm64)

Version/Channel Information:

Nightly, mac-arm64

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    No
  • Does the issue resolve itself when disabling Brave Rewards?
    No
  • Is the issue reproducible on the latest version of Chrome?
    No
@atuchin-m
Copy link
Contributor Author

Probably it's a result of chromium patches in #35677

@atuchin-m atuchin-m added the bug label May 13, 2024
@arthuredelstein
Copy link

arthuredelstein commented May 13, 2024 •
edited

So far I tried reverting

but that didn't fix the problem.

@atuchin-m
Copy link
Contributor Author

1.65.132 Chromium: 124.0.6367.202 (Official Build) (arm64) is unaffected to me

@arthuredelstein arthuredelstein self-assigned this May 13, 2024
@fallaciousreasoning fallaciousreasoning mentioned this issue May 15, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone May 15, 2024
This was referenced May 15, 2024
Merged
Merged
@kjozwiak
Copy link
Member

The above requires 1.66.10 or higher for 1.66.x verification 👍

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 16, 2024 •
edited

Verification PASSED on

Brave | 1.66.110 Chromium: 125.0.6422.60 (Official Build) (64-bit)
-- | --
Revision | de593d76e2ca4d02faa85bf1ca27bcf3ee46793c
OS | Windows 10 Version 22H2 (Build 19045.4412)

Using the STR/Cases outlined via #38258 (comment), ensured that refreshing brave://settings/security doesn't enable Secure DNS if it's already disabled as per the following:

SecureDNS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arthuredelstein arthuredelstein

Labels
bug feature/settings OS/Desktop QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.66.x - Release
Development

Successfully merging a pull request may close this issue.

[Nala]: Ensure change event bubbles brave/brave-core
5 participants
@arthuredelstein @kjozwiak @GeetaSarvadnya @brave-builds @atuchin-m