Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Callback opens old gui if already plotted #1678

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Callback opens old gui if already plotted #1678

wants to merge 5 commits into from

Conversation

egolol
Copy link
Collaborator

@egolol egolol commented Oct 23, 2023

This needs the ID of the element to be edited, I thought about comparing elements but it is kind of slow

@egolol egolol self-assigned this Oct 23, 2023
@egolol egolol linked an issue Oct 23, 2023 that may be closed by this pull request
Call the old panel with callback button instead of creating new #1668
Open
@hanzh346
Copy link
Collaborator

It feels like the old way now, the button is calling a new panel
image

@egolol
Copy link
Collaborator Author

egolol commented Oct 24, 2023

@hanzh346 You have to read the comments, which say you have to edit the ID

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanzh346 hanzh346 hanzh346 approved these changes

@giovannivolpe giovannivolpe Awaiting requested review from giovannivolpe

At least 2 approving reviews are required to merge this pull request.

Assignees

@egolol egolol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Call the old panel with callback button instead of creating new
3 participants
@egolol @hanzh346 @giovannivolpe