-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Dataset Classes #543
Comments
Okay, I'm thinking here @robintibor. I'm not confident about this nomenclature. I would remove EEG from the beginning, we also have support for ecog and any mne format (ieeg, meg...). It would be shorter, which would be great. |
Hm, atm though this is also in other parts of Braindecode, namely Like |
How about just Brain in the prefix? |
Looks nice for me, what do you think @robintibor? |
So for me a BrainDataset implies a dataset of the Brain, e.g. an anatomical atlas/coordinates etc. |
you have now EEGClassifier and EEGRegressor. I would try to be consistent so EEGDataset so an EEGClassifier will be fed by an EEGDataset. |
I'm ok with the first proposal @robintibor and @agramfort |
Should we focus on this? @robintibor |
I would suggest to rename the dataset classes as follows:
BaseDataset
->EEGRawDataset
BaseConcatDataset
->EEGConcatDataset
Think this is more straightforward,
Base
has been confusing for me, and then structure is:EEGConcatDataset
is a concatenation of eitherEEGRawDataset
orEEGWindowsDataset
What do you think @bruAristimunha ? Assuming #515 is merged.
The text was updated successfully, but these errors were encountered: