Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test tidyup #936

Open
braindigitalis opened this issue Oct 10, 2023 · 9 comments 路 May be fixed by #1090
Open

Unit test tidyup #936

braindigitalis opened this issue Oct 10, 2023 · 9 comments 路 May be fixed by #1090
Assignees
Labels
build Issue or Pull Request related to the build process code Improvements or additions to code. enhancement New feature or request good first issue Good for newcomers hacktoberfest-accepted Issues tagged for hacktoberfest

Comments

@braindigitalis
Copy link
Contributor

test.cpp and friends are large and unwieldy. it is now over 2000 lines, this is 馃あ - as a small project this could do with tidying up and breaking down into smaller files. anything under the unittest folder will be linked into one executable.

This is an ideal first issue for an intermediate developer wanting to contribute to D++.

@braindigitalis braindigitalis added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed hacktoberfest-accepted Issues tagged for hacktoberfest build Issue or Pull Request related to the build process code Improvements or additions to code. labels Oct 10, 2023
@braindigitalis braindigitalis linked a pull request Oct 14, 2023 that will close this issue
5 tasks
@braindigitalis
Copy link
Contributor Author

braindigitalis commented Oct 22, 2023

#948 introduced crases and caused unit tests to fail:

coro: offline job                                            FAIL
coro: offline coroutine                                      FAIL
coro: offline task                                           FAIL
coro: offline async                                          FAIL
coro: online event handler                                   PASS
coro: online api calls                                       PASS
coro: online mumbo jumbo in event handler                    SKIPPED

Execution finished in 55.809 seconds.
Failed: 4 Passed: 138 Skipped: 19 Percentage: 97.18%
terminate called after throwing an instance of 'std::system_error'
  what():  Invalid argument
Aborted (core dumped)

As such this breaks CI so we had to roll it back. Anyone welcome to try again but we must make sure that it doesnt break the tests.

The failing tests are skipped when ran as part of a PR (you dont have access to the token) but when it is merged into dev the online tests are ran. This was not tested with a token with the online tests before submitting the PR.

@Jaskowicz1 Jaskowicz1 linked a pull request Oct 30, 2023 that will close this issue
This was unlinked from pull requests Oct 30, 2023
@Jaskowicz1
Copy link
Contributor

This is still open if anyone wants to take this!

@Jaskowicz1
Copy link
Contributor

Gonna take this on myself. I will be basing it off #948 as we agreed that the format was good.

@Jaskowicz1 Jaskowicz1 self-assigned this Nov 14, 2023
@Jaskowicz1
Copy link
Contributor

I'd put this off for a bit as I faced issues with Mac and whatnot, will look to maybe pick this up over Christmas if no-one else does (as I am busy until then).

Copy link
Contributor

This issue has had no activity and is being marked as stale. If you still wish to continue with this issue please comment to reopen it.

@github-actions github-actions bot added the Stale label Jan 22, 2024
@Jaskowicz1
Copy link
Contributor

Reminder, we're looking for people to complete this project! I'll post this in the Discord too!

@Jaskowicz1 Jaskowicz1 removed their assignment Jan 25, 2024
@github-actions github-actions bot removed the Stale label Jan 26, 2024
@mayankag32
Copy link

Hello @Jaskowicz1, I would like to work on this issue, is it still open?

@braindigitalis
Copy link
Contributor Author

sure feel free to grab it, please do not add any external dependencies such as catch2!

@Jaskowicz1
Copy link
Contributor

Going to actually take this on myself this time.

@Jaskowicz1 Jaskowicz1 self-assigned this Feb 19, 2024
@Jaskowicz1 Jaskowicz1 linked a pull request Feb 19, 2024 that will close this issue
5 tasks
@Jaskowicz1 Jaskowicz1 linked a pull request Feb 23, 2024 that will close this issue
5 tasks
@Jaskowicz1 Jaskowicz1 removed the help wanted Extra attention is needed label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issue or Pull Request related to the build process code Improvements or additions to code. enhancement New feature or request good first issue Good for newcomers hacktoberfest-accepted Issues tagged for hacktoberfest
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

3 participants