Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for other encryption / decryption methods supported by discord #1134

Open
Kaydax opened this issue Apr 28, 2024 · 4 comments
Open
Labels
audio audio issues or feature requests enhancement New feature or request

Comments

@Kaydax
Copy link

Kaydax commented Apr 28, 2024

Is your feature request related to a problem? Please describe.
Currently DPP only supports xsalsa20_poly1305, however discord supports all of these other types:

  • aead_aes256_gcm_rtpsize
  • aead_aes256_gcm
  • aead_xchacha20_poly1305_rtpsize
  • xsalsa20_poly1305_lite_rtpsize
  • xsalsa20_poly1305_lite
  • xsalsa20_poly1305_suffix

Describe the solution you'd like
I would like to see all modes supported, or at least rtpsize be implemented.

There is full documentation on how rtpsize works here: https://git.kaydax.xyz/w/algos/src/branch/main/doc/crypt.md

Describe alternatives you've considered
None

Additional context
This has also been implemented into BetterDisco here: elderlabs/BetterDisco@d988d6a8

@braindigitalis
Copy link
Contributor

we cant use that example code and really we shouldnt even look at it - it is LGPL 3.0 only.
Similarly we should not reference betterdiscord or any unofficial client fork. I'm sure we can figure something out though.

@Kaydax
Copy link
Author

Kaydax commented Apr 28, 2024

we cant use that example code and really we shouldnt even look at it - it is LGPL 3.0 only. Similarly we should not reference betterdiscord or any unofficial client fork. I'm sure we can figure something out though.

I removed the link to the example code from algos because of the license, however the crypt documentation is CC-BY-SA meaning its allowed to be used. Also BetterDisco is not a client modification, its a continuation of disco, the discord bot python library made by b1nzy

@Kaydax
Copy link
Author

Kaydax commented Apr 28, 2024

We just relicensed the code that is referenced in the docs to be LGPL OR Apache 2.0, so there is no longer any licensing problems: https://git.kaydax.xyz/w/algos/src/branch/main/src/module/util/crypt_impl.cc

@braindigitalis
Copy link
Contributor

great to hear :D

@braindigitalis braindigitalis added enhancement New feature or request audio audio issues or feature requests labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audio audio issues or feature requests enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants