Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix memory leak on libstdc++ #1112

Merged
merged 2 commits into from
Mar 30, 2024
Merged

fix memory leak on libstdc++ #1112

merged 2 commits into from
Mar 30, 2024

Conversation

Mishura4
Copy link
Member

fixes #1091
truly a GNU moment

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Mar 29, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 29, 2024 •
edited

✅ Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 5bf5a5a
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/66072f1563a8cc000812459b
😎 Deploy Preview https://deploy-preview-1112--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Mishura4 Mishura4 marked this pull request as draft March 29, 2024 20:45
@Mishura4 Mishura4 marked this pull request as ready for review March 29, 2024 20:46
@Mishura4 Mishura4 force-pushed the cooking branch 2 times, most recently from 6f26cd5 to c9a4a01 Compare March 29, 2024 20:58
@Mishura4
fix: fix memory leak on libstdc++
cc5dd0a 
ditched the std::multimap in queues.cpp for a sorted vector, and established clearer ownership of the request data
yes the requests are still kept alive for a minute
@Mishura4
misc: the beginning of a new era
5bf5a5a
@Jaskowicz1
Copy link
Contributor

37ed9925-8d98-4e65-89c2-fbbab8659bca_text

@Jaskowicz1 Jaskowicz1 linked an issue Mar 29, 2024 that may be closed by this pull request
Memory leak in request_queue when sending messages with files #1091
Open
@Jaskowicz1
Copy link
Contributor

Confirmed fixed on WSL

Memory currently at: 14127104
[2024-03-29 21:53:52] DEBUG: Shards started.
Memory currently at: 14127104
Memory currently at: 14127104
Memory currently at: 14127104
Memory currently at: 14127104
Memory currently at: 14127104
Memory currently at: 14127104
Memory currently at: 14127104

@braindigitalis braindigitalis merged commit 68e7477 into brainboxdotcc:dev Mar 30, 2024
43 checks passed
@Jaskowicz1
Copy link
Contributor

Confirmed fixed on WSL

Memory currently at: 14127104
[2024-03-29 21:53:52] DEBUG: Shards started.
Memory currently at: 14127104
Memory currently at: 14127104
Memory currently at: 14127104
Memory currently at: 14127104
Memory currently at: 14127104
Memory currently at: 14127104
Memory currently at: 14127104

This seems to be a false positive from me. My image wasn't being sent so no memory was ever being added.

The issue still persists:

Memory currently at: 18853888
[2024-03-30 09:07:55] DEBUG: Shards started.
Memory currently at: 39813120
Memory currently at: 46161920
Memory currently at: 49405952
Memory currently at: 52580352
Memory currently at: 55758848
Memory currently at: 58998784
Memory currently at: 65417216
Memory currently at: 69402624
Memory currently at: 72646656
Memory currently at: 75821056
Memory currently at: 78794752
Final Mem Check - Memory currently at: 78794752
Final Mem Check - Memory currently at: 78794752
Final Mem Check - Memory currently at: 78794752
Final Mem Check - Memory currently at: 78794752
Final Mem Check - Memory currently at: 78794752
Final Mem Check - Memory currently at: 78794752
Final Mem Check - Memory currently at: 78794752
Final Mem Check - Memory currently at: 78794752
Final Mem Check - Memory currently at: 78794752
Final Mem Check - Memory currently at: 78794752
Final Mem Check - Memory currently at: 78794752
Final Mem Check - Memory currently at: 78794752
Final Mem Check - Memory currently at: 38891520

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braindigitalis braindigitalis braindigitalis approved these changes

Assignees
No one assigned
Labels
code Improvements or additions to code. documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory leak in request_queue when sending messages with files
3 participants
@Mishura4 @Jaskowicz1 @braindigitalis