Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaxConns parameter? #103

Open
enugentdt opened this issue May 23, 2019 · 1 comment
Open

MaxConns parameter? #103

enugentdt opened this issue May 23, 2019 · 1 comment

Comments

@enugentdt
Copy link

enugentdt commented May 23, 2019

Hiya,

I'm using this library for an application that absolutely pounds a memcached server. Something on the order of 8k queries per second is on my dev branch. However, because memcached is limited by default to 1024 simultaneous connections, I keep overrunning that limit.

Would it be worthwhile to add a MaxConns parameter to the Client object? I'm already working on it on my own fork, but if you'd like, when I finish it, I'm happy to PR it back in.

Alternatively, I could also stop trying to kill my memcached server, or maybe not run 8k queries per second. Eh, this is more fun though.

Thanks!

Edit: My changes are done, come take a look: https://github.com/demilletech/gomemcache

@bradfitz
Copy link
Owner

Rather than add new config knobs, I'd rather just fix the implementation to pipeline request/responses onto the existing connections, rather than make so many.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants