Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky call.ustack_* tests in CI #3080

Open
danobi opened this issue Mar 21, 2024 · 2 comments
Open

Fix flaky call.ustack_* tests in CI #3080

danobi opened this issue Mar 21, 2024 · 2 comments
Assignees
Labels
bug Something isn't working ci Issues or PRs related to Github Actions CI difficulty: hard

Comments

@danobi
Copy link
Member

danobi commented Mar 21, 2024

The four tests in question:

call.ustack_stack_mode_env_bpftrace
call.ustack_stack_mode_env_override
call.ustack_stack_mode_env_perf
call.ustack_stack_mode_env_raw

They run locally just fine - I couldn't get them to fail even once after many runs.

But in CI, they at least 1 fails pretty frequently. On the order of 1/10 jobs. So once per PR.

I debugged as far down as std::cout having badbit 0 set after a write. It's really confusing why. It cannot be reproduced locally. My current best guess is that somewhere in all the layers of shelling out there's a misbehaving pipe that hangs up too early.

@danobi danobi added bug Something isn't working ci Issues or PRs related to Github Actions CI difficulty: hard labels Mar 21, 2024
@danobi danobi self-assigned this Mar 21, 2024
@danobi
Copy link
Member Author

danobi commented Mar 21, 2024

While debugging in ongoing, disable tests in CI for now: #3078

Note "for now" is optimistic. I'm quickly running out of ideas

@danobi
Copy link
Member Author

danobi commented Mar 27, 2024

I still think the real bug is in the runtime test suite somewhere, and related to pipes, but unclear why it only affects ustack tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci Issues or PRs related to Github Actions CI difficulty: hard
Projects
None yet
Development

No branches or pull requests

1 participant