New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIXME when iovisor/bcc#2064 is merged #3061

Open

eslerm opened this issue Mar 14, 2024 · 0 comments

Labels

eslerm commented Mar 14, 2024 •

edited

There are two code comments suggesting re-implementations when iovisor/bcc#2064 is merged. Since the PR is merged, could these comments be reviewed?

bpftrace/src/ast/irbuilderbpf.cpp

Line 718 in 5aa2ffa

// FIXME use attach_point->target when iovisor/bcc#2064 is merged

bpftrace/src/attached_probe.cpp

Line 1239 in 5aa2ffa

// FIXME when iovisor/bcc#2064 is merged, optionally pass probe_.path

eslerm added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment