Skip to content
This repository has been archived by the owner on Aug 9, 2020. It is now read-only.

Refactor Dialogs #279

Open
1 of 2 tasks
HaGuesto opened this issue Jul 2, 2018 · 2 comments
Open
1 of 2 tasks

Refactor Dialogs #279

HaGuesto opened this issue Jul 2, 2018 · 2 comments
Labels
type/chore Things that don't change the app from a user's point of view, but need to be done

Comments

@HaGuesto
Copy link
Member

HaGuesto commented Jul 2, 2018 •
edited

We usage of Material-UI dialogs is inflationary (Creating, editing boxes and products). We are running into problems since we want to use maybe a Dialog in the menu (#92 and #221) and maybe we soon need Dialogs in the Dialogs.

Anyway, according to Material Design we should only use Dialogs for

  • Errors that block an app’s normal operation
  • Critical information that requires a specific user task, decision, or acknowledgement

So, let's refactor the dialogs according to #274

  • ProductDialog.js
  • BoxDialog

@bfirsh @barto74 Do you have a different opinion?
@HaGuesto HaGuesto added type/enhancement New feature or request type/chore Things that don't change the app from a user's point of view, but need to be done and removed type/enhancement New feature or request labels Jul 2, 2018
@HaGuesto
Copy link
Member Author

@jamescrowley you refactored the ProductDialog, right?

@jamescrowley
Copy link
Contributor

Yep still need to do boxes, but maybe not a priority for now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/chore Things that don't change the app from a user's point of view, but need to be done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamescrowley @HaGuesto