Skip to content
This repository has been archived by the owner on Aug 9, 2020. It is now read-only.

Menu should be scrollable #206

Open
bfirsh opened this issue Jun 20, 2018 · 6 comments
Open

Menu should be scrollable #206

bfirsh opened this issue Jun 20, 2018 · 6 comments
Labels
good first issue Good for newcomers type/bug Something isn't working

Comments

@bfirsh
Copy link
Contributor

bfirsh commented Jun 20, 2018

The menu doesn't scroll and we're right on the borderline of what can fit in the menu on an iPhone 5 sized screen. With things like #23, it's going to get too long.

The menu should be scrollable, somehow.

The menu is a Material UI drawer. Here are the docs: https://material-ui.com/demos/drawers/

@bfirsh bfirsh added type/bug Something isn't working good first issue Good for newcomers TripAdvisor HackDay labels Jun 20, 2018
@jclarkin
Copy link
Contributor

jclarkin commented Jun 20, 2018

@bfirsh I tested this in Chrome resized for mobile and Firefox. Looks like the menu drawer does allow scrolling. In which browser did you encounter this issue?

@bfirsh
Copy link
Contributor Author

bfirsh commented Jun 20, 2018

Ah - interesting. Mobile Safari. This is me recalling it not working from a few weeks ago, so maybe it is fixed now. Let me double check.

@bfirsh
Copy link
Contributor Author

bfirsh commented Jun 20, 2018

Yeah - it doesn't seem to work on mobile safari. When you swipe up and down on the menu, it scrolls the page behind it, not the menu. Makes it rather hard to get to the "sign out" button...

@acournoyer1
Copy link
Contributor

I'll grab this one, literally just fixed 2 or 3 instances of it on our site

acournoyer1 added a commit to acournoyer1/boxwise that referenced this issue Jun 20, 2018
@bfirsh bfirsh mentioned this issue Jun 20, 2018
bfirsh pushed a commit that referenced this issue Jun 20, 2018
@bfirsh
Copy link
Contributor Author

bfirsh commented Jun 20, 2018

This has been fixed on android but still up for grabs on iOS - see #220

@spielhoelle
Copy link

Cannot reproduce. Menu scrolls on chrome, ff, iphone mobile safari. On Iphone it seemed to be a bit buggy but worked in the end.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants