Skip to content
This repository has been archived by the owner on Aug 9, 2020. It is now read-only.

Make instascan QR scanner work on iOS #157

Open
bfirsh opened this issue Jun 9, 2018 · 4 comments
Open

Make instascan QR scanner work on iOS #157

bfirsh opened this issue Jun 9, 2018 · 4 comments
Labels
area/warehouse type/chore Things that don't change the app from a user's point of view, but need to be done

Comments

@bfirsh
Copy link
Contributor

bfirsh commented Jun 9, 2018

We want to use https://github.com/schmich/instascan for scanning QR codes, but it doesn't seem to work on iOS.

All the APIs seem to be in place, but something doesn't seem to be plumbed up correctly. It asks for permission, displays a camera icon in the URL bar, but then doesn't actually display anything on the screen.

See also #25.

@bfirsh bfirsh added the good first issue Good for newcomers label Jun 9, 2018
@rubenspgcavalcante
Copy link
Contributor

So after going thru the open issues, it seems instascan development is a little inactive. Some people already asked about updating the webRTC package of the lib so it can work on iOS devices

There's a plenty of PR's stacking too, so maybe even if we try to do one, we'll need to wait a while :(

@bfirsh
Copy link
Contributor Author

bfirsh commented Jun 12, 2018

Looks like we could just fork it though! schmich/instascan#112

@rubenspgcavalcante
Copy link
Contributor

At least I've put instascan as per-dep. of react-instascan, so using it from the fork should work :)

@HaGuesto HaGuesto added TripAdvisor HackDay type/chore Things that don't change the app from a user's point of view, but need to be done area/warehouse and removed TripAdvisor HackDay good first issue Good for newcomers labels Jun 19, 2018
@HaGuesto
Copy link
Member

@rubenspgcavalcante can we close this issue?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/warehouse type/chore Things that don't change the app from a user's point of view, but need to be done
Projects
None yet
Development

No branches or pull requests

3 participants