Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: File header comments get parsed as comment on first string (JS file format) #588

Open
patcon opened this issue Jun 15, 2020 · 0 comments

Comments

@patcon
Copy link

patcon commented Jun 15, 2020

Hi! Thanks for this project!

Very low priority "bug":

When processing JS files of proper format, a header comment at the top of the file (like the sort used for copyright) gets included as the comment on the first string. I observed this when there was otherwise no comment on the first string.

Potential Solution

Don't start parsing strings from the file until the line with "export" on it, or some other representative token where the hash begins.

(I'm not blocked on this, as I believe our project can remove the header comment, so no urgency from me!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant