Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

true/false fields inaccurate for 'getCanSeeManagedUsers()' and 'getIsSyncEnabled()' #386

Open
paapfly opened this issue Jan 27, 2017 · 2 comments
Labels
breaking Added to issued that will introduce breaking changes to SDK enhancement Added to issues that describes enhancements

Comments

@paapfly
Copy link

paapfly commented Jan 27, 2017

When using the Box Java SDK, the 'getCanSeeManagedUsers()' and 'getIsSyncEnabled()' methods on the BoxUser.Info object always return 'false'. These two flags are set to 'true' on users in our org but always return false. We need the Java SDK updated to reflect the actual state of the flags on the user.

@gcurtis
Copy link
Contributor

gcurtis commented Feb 6, 2017

Hi @paapfly, can you confirm that you're passing in these fields in through the fields parameters? They're not returned by the API by default.

@mattwiller
Copy link

There's definitely a workaround available here (making sure to pass these fields to getInfo(), but this really seems like a case of bad defaults. The fact that this field defaults to false when the field was not requested introduces uncertainty when the BoxUser.Info object is used: was the field actually false or just not requested by whoever generated the object?

We should look into how to address this sort of confusion around optional fields in the future, e.g. by using Boolean or Optional in some way.

@carycheng carycheng added the enhancement Added to issues that describes enhancements label Jan 5, 2018
@mattwiller mattwiller added the breaking Added to issued that will introduce breaking changes to SDK label Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Added to issued that will introduce breaking changes to SDK enhancement Added to issues that describes enhancements
Projects
None yet
Development

No branches or pull requests

4 participants