Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't consume newer version of Rust via rustup update stable #461

Open
jpmcb opened this issue Jun 6, 2023 · 0 comments
Open

Don't consume newer version of Rust via rustup update stable #461

jpmcb opened this issue Jun 6, 2023 · 0 comments

Comments

@jpmcb
Copy link
Contributor

jpmcb commented Jun 6, 2023

In the following GitHub workflow for CI builds:

- run: rustup update stable

we are consuming the newest version of rust "locally" which pulls down dependencies that get fed into the docker container that uses the bottlerocket sdk. This leads to the possibility of the "local" version of rust fast-forwarding from the version in the sdk. For example, at the time of this writing, the sdk is on 1.69, and in these breaking CI builds, rustup consumes 1.70:

https://github.com/bottlerocket-os/bottlerocket-update-operator/actions/runs/5189657965/jobs/9355968232?pr=350

We may be able to forgo doing the whole operation of getting rust "locally" and instead remove the --network=none line in the docker container so it can just do it all from within the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant