Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.2.0: Controller should gracefully handle node deletion coinciding with a WATCH stream reset #106

Open
cbgbt opened this issue Nov 2, 2021 · 1 comment
Open

0.2.0: Controller should gracefully handle node deletion coinciding with a WATCH stream reset #106

cbgbt opened this issue Nov 2, 2021 · 1 comment
Assignees
@cbgbt
Labels
component/controller
Milestone
Tech debt

Comments

@cbgbt
Copy link
Contributor

cbgbt commented Nov 2, 2021

Issue or Feature Request:

The controller uses into_iter_touched(), which can miss deletion events under certain circumstances (see the linked docs).

We need to periodically refresh the entire Store object in the controller in case deletion events are missed.
@cbgbt cbgbt added this to the brupop 0.2.0 milestone Nov 2, 2021
@cbgbt cbgbt self-assigned this Nov 2, 2021
@cbgbt cbgbt changed the title 0.2.0: Controller should gracefully handle node deletion 0.2.0: Controller should gracefully handle node deletion coinciding with a WATCH stream reset Nov 2, 2021
@cbgbt cbgbt modified the milestones: brupop 0.2.0, brupop 0.2.1 Dec 3, 2021
@cbgbt cbgbt removed the 0.2.0-dev label Apr 5, 2022
@cbgbt
Copy link
Contributor Author

cbgbt commented Apr 5, 2022 •
edited

Rather than into_iter_touched(), we actually use try_flatten_touched(), which uses into_iter_touched().

@cbgbt cbgbt modified the milestones: brupop 0.2.1, Tech debt Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cbgbt cbgbt

Labels
component/controller
Projects
None yet
Milestone
Tech debt
Development

No branches or pull requests
1 participant
@cbgbt