Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple *History problems #325

Open
jbbarth opened this issue Jan 31, 2018 · 0 comments
Open

Multiple *History problems #325

jbbarth opened this issue Jan 31, 2018 · 0 comments
Assignees
Labels

Comments

@jbbarth
Copy link
Collaborator

jbbarth commented Jan 31, 2018

A few problems I got with history concepts in both swf and simpleflow:

  • inconsistent timestamp keys for "tasks" other than activities (signals, timers, markers) => see 7b30a37#commitcomment-27044383
  • simpleflow's History.parse() should be automatic (lost 5 minutes again today figuring out why my "history.activities" was empty)
  • simpleflow's History expects that events are sorted by event ID ; it happens that our consolidated json produced by webflow sort in reverse order (and use to not sort much) => this should be done before parsing ; this is for instance implicit here ; I didn't check if swf's History had such problems

Overall working with two levels of history is a pain. We may want to merge them, or clarify their respective roles and change naming.

@jbbarth jbbarth self-assigned this Jan 31, 2018
@jbbarth jbbarth added the bug label Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant