Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve swf.format when message is too long #315

Open
jbbarth opened this issue Nov 2, 2017 · 1 comment
Open

Improve swf.format when message is too long #315

jbbarth opened this issue Nov 2, 2017 · 1 comment
Assignees
Labels

Comments

@jbbarth
Copy link
Collaborator

jbbarth commented Nov 2, 2017

@ampelmann noticed that with recent changes on swf.format module, the code raises but that may leave tasks running while in fact they are not. This is especially true if we don't have a heartbeat timeout on the task, it can last for hours while in fact, the RespondActivityTaskCompleted/Failed has failed.

Proposed changes:

  • we could replace the message with a default one, like "ERROR: field too long check your logs"
  • for the "result" field, I would NOT have a JSON parseable message, since we take the risk of propagating silent errors down the road ; maybe a RespondActivityTaskCompleted could be turned into a RespondActivityTaskFailed with the message above
  • for the "input" field, the simplest behaviour would be to fail the workflow directly ; it's not nice for optional ones but we're going to scratch our head against the wall otherwise

What do you think @ybastide @ampelmann ?

@jbbarth jbbarth added the bug label Nov 2, 2017
@jbbarth jbbarth self-assigned this Nov 2, 2017
@ybastide
Copy link
Contributor

ybastide commented Nov 2, 2017

"check your logs": Ha! 🙂
Yes, seems reasonable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants