Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to kill child processes #291

Open
benjastudio opened this issue Aug 23, 2017 · 3 comments
Open

Add an option to kill child processes #291

benjastudio opened this issue Aug 23, 2017 · 3 comments

Comments

@benjastudio
Copy link
Contributor

It would be useful to add an option to force simpleflow to kill child processes in simpleflow.execute, on exit, eg:

python -m simpleflow.execute x.launch_process '{"args": []}' --kill-children

Somewhere in x.py:

import subprocess, time
def  launch_process():
    subprocess.Popen(['sleep', '600'])
    time.sleep(2)

With --kill-children simpleflow should kill sleep process after that launch_process is executed.

@jbbarth
Copy link
Collaborator

jbbarth commented Aug 23, 2017

Note for future problems that you already solved: no need to make an issue just to issue the PR 3 minutes after, you can issue the PR directly in such cases, with the explanation in the PR description. As you want, it's OK like that too, I just don't do it myself and don't want you to feel forced to do that.

@ybastide
Copy link
Contributor

^ My fault 🙂

@benjastudio
Copy link
Contributor Author

And there is the proof in the backlog 🕵️‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants