Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building ret-sync for Ghidra 10.3.1 #108

Open
saidelike opened this issue Jul 10, 2023 · 7 comments
Open

Building ret-sync for Ghidra 10.3.1 #108

saidelike opened this issue Jul 10, 2023 · 7 comments

Comments

@saidelike
Copy link
Contributor

See NationalSecurityAgency/ghidra#4962

With the below changes, it builds fine:

C:\ret-sync>git diff --cached
diff --git a/ext_ghidra/src/main/help/help/shared/Frontpage.css b/ext_ghidra/src/main/help/help/shared/DefaultStyle.css
similarity index 100%
rename from ext_ghidra/src/main/help/help/shared/Frontpage.css
rename to ext_ghidra/src/main/help/help/shared/DefaultStyle.css
diff --git a/ext_ghidra/src/main/help/help/topics/retsync/help.html b/ext_ghidra/src/main/help/help/topics/retsync/help.html
index 8f858d2..1f9d6a1 100644
--- a/ext_ghidra/src/main/help/help/topics/retsync/help.html
+++ b/ext_ghidra/src/main/help/help/topics/retsync/help.html
@@ -10,7 +10,7 @@
     <META name="ProgId" content="FrontPage.Editor.Document">

     <TITLE>Skeleton Help File for a Module</TITLE>
-    <LINK rel="stylesheet" type="text/css" href="../../shared/Frontpage.css">
+    <LINK rel="stylesheet" type="text/css" href="help/shared/DefaultStyle.css">
   </HEAD>

   <BODY>
@n3x77
Copy link

n3x77 commented Aug 1, 2023

Thanks @saidelike for the hint, also works ion current ghidra version 10.3.2.

@sud0why
Copy link

sud0why commented Aug 16, 2023

Thanks too!

kexplo added a commit to kexplo/ret-sync that referenced this issue Sep 9, 2023
@SweDevDoesTech
Copy link

Thanks!

@ognz
Copy link

ognz commented Dec 13, 2023

Thank you so much, @saidelike !
Confirmed working on Ghidra 10.5 DEV (20231213).

@Ebiroll
Copy link

Ebiroll commented Jan 17, 2024

Also works for ghidra_11.0_PUBLIC

@rblakeslee
Copy link

Also works for ghidra_11.0_PUBLIC

I tried over and over on ubuntu to compile this with the changes, and no matter what it kept failing at the help file, with errors like this:

Exception in thread "main" ghidra.util.exception.AssertException: Errors parsing HTML file: help.html
Incorrect stylesheet defined - none match help/shared/DefaultStyle.css in file /home/box/ret-sync/ext_ghidra/src/main/help/help/topics/retsync/help.html
Discovered stylesheets: [/home/box/ret-sync/ext_ghidra/src/main/help/help/shared/DefaultStyle.css]

DefaultStyle is referenced in the HTML, renamed in the shared folder, and it says it discovered it, and fails anyway.
I'm at my wits end of this, so I just forced it to run the 10.2 version that I could find pre-built. I would prefer to have it compile, so if anyone has any ideas as to what's going on...

@Ebiroll
Copy link

Ebiroll commented Apr 14, 2024

Also works for ghidra_11.0_PUBLIC

I tried over and over on ubuntu to compile this with the changes, and no matter what it kept failing at the help file, with errors like this:

Exception in thread "main" ghidra.util.exception.AssertException: Errors parsing HTML file: help.html Incorrect stylesheet defined - none match help/shared/DefaultStyle.css in file /home/box/ret-sync/ext_ghidra/src/main/help/help/topics/retsync/help.html Discovered stylesheets: [/home/box/ret-sync/ext_ghidra/src/main/help/help/shared/DefaultStyle.css]

Do not forget the important step, rename from ext_ghidra/src/main/help/help/shared/Frontpage.css to ext_ghidra/src/main/help/help/shared/DefaultStyle.css . I used Alpine in WSL2. Also note that I edited Extensions/Ghidra/Skeleton/src/main/help/help/topics/skeleton/help.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants