Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Includes possible non-free content #27

Open
jelmer opened this issue Apr 12, 2014 · 5 comments
Open

Includes possible non-free content #27

jelmer opened this issue Apr 12, 2014 · 5 comments
Assignees

Comments

@jelmer
Copy link
Contributor

jelmer commented Apr 12, 2014

breadability ships a number of documents for testing that are possibly restricted because they are copyrighted and not BSD-licensed.

Would it be possible to use alternatives, or possibly fetch them during the test process so they don't have to be distributed?

This makes it harder to package breadability for Debian.

@mitechie
Copy link
Member

So just to make sure, this is in reference to the web content used for test cases that we have? Would something like moving the tests out of the actual package help/hurt the cause? We could try to 'make up' content that fits the test case, but it's obviously important that once we hit a bug it's easy/best to get that content and make sure we parse it correctly.

@jelmer
Copy link
Contributor Author

jelmer commented Apr 12, 2014

On Sat, Apr 12, 2014 at 10:36:24AM -0700, Rick Harding wrote:

So just to make sure, this is in reference to the web content used for test cases that we have? Would something like moving the tests out of the actual package help/hurt the cause? We could try to 'make up' content that fits the test case, but it's obviously important that once we hit a bug it's easy/best to get that content and make sure we parse it correctly.
Yep, it's about the web content. Moving it out of the actual package
would help a lot, because that means I can just package the upstream
source without the tests.

Making up contents would be ideal (because it means I can still run
the tests for every package build), but I'm guessing is also the most
work.

Cheers,

Jelmer

@mitechie
Copy link
Member

Ok cool, I'll try to pull the tests out as that'll be fast and unblock you and then can see if we can mimic the issue the site gave us and replicate it in a 'generic' way as follow ups.

@mitechie mitechie self-assigned this Apr 12, 2014
@mitechie
Copy link
Member

I've uploaded 0.1.20 that does not include the tests in the source build. We'll keep that as a pure development tool for now and use in CI while we try to find a better way to generate test files that aren't copyrighted material.

@jelmer
Copy link
Contributor Author

jelmer commented Apr 14, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants