Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYI : updates version 84,85,89 and test corrections #23

Open
anantshri opened this issue Oct 29, 2022 · 3 comments
Open

FYI : updates version 84,85,89 and test corrections #23

anantshri opened this issue Oct 29, 2022 · 3 comments

Comments

@anantshri
Copy link

Hi @bongtrop Thanks for the nice tool.

I have been working on updating few things here : https://github.com/cyfinoid/hbctool

I see 84,85 support got merged recently hence cant open a clear pull request. Following changes are available in my branch if you want to cherrypick

  1. Version support added 84 (via niosega), 85,89,83
  2. Test cases are now running some fixing was needed
  3. Added a readme on how to add new versions.

Feel free to pick and choose

@bongtrop
Copy link
Owner

Awesome contribution. I'm working on it. I will merge it soon.

@bongtrop
Copy link
Owner

I'm working on it at #25.

@amirhoseinsb
Copy link

Not Working script for me

[*] Disassemble 'index.android.bundle' to 'test_hasm' path
Traceback (most recent call last):
File "/home/amir/.local/bin/hbctool", line 8, in
sys.exit(main())
File "/home/amir/.local/lib/python3.10/site-packages/hbctool/init.py", line 61, in main
disasm(args['<HBC_FILE>'], args['<HASM_PATH>'])
File "/home/amir/.local/lib/python3.10/site-packages/hbctool/init.py", line 33, in disasm
hbco = hbc.load(f)
File "/home/amir/.local/lib/python3.10/site-packages/hbctool/hbc/init.py", line 29, in load
assert version in HBC, f"The HBC version ({version}) is not supported."
AssertionError: The HBC version (85) is not supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants