Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle plugin transition #105

Open
TWiStErRob opened this issue Mar 23, 2024 · 1 comment
Open

Gradle plugin transition #105

TWiStErRob opened this issue Mar 23, 2024 · 1 comment

Comments

@TWiStErRob
Copy link
Contributor

In #103 (comment) you mentioned a transition.

I'm not sure what happened, did you get hired by JetBrains? Or have you always worked there, some context would be nice... anyways, getting sidetracked :)

I would recommend this:

  • On upgrade apply the Kotlin built-in plugin
  • Print a big logger.warn to replace the plugin
  • for Renovate: pull a replacement config.

More info on replacements:
https://docs.renovatebot.com/presets-replacements/

How will this help?
replacements:all is included by recommended, so probably "most" users will receive it: https://docs.renovatebot.com/presets-config/#configrecommended

Deployment:

  • Pull core Renovate config update, referencing the "next" version
  • Wait for it to get released to GitHub.com and propagate otherwise via normal updates.
  • Release the "next" transition version
  • Renovate will open PRs replacing the plugin id and version (won't use the kotlin("...") syntax, but I think that's acceptable for automagic.
@bnorm
Copy link
Owner

bnorm commented Mar 24, 2024

Thanks for the info! I was unaware of the Renovate replacement configuration, so I'll definitely take a look at that. I'm still undecided though on if I want a clean upgrade or just fail the build. I think failing the build will be more annoying but will also be the most obvious for all type of upgrades, automatic or not. I worry that a warning and passing build will just go unnoticed, and a Renovate replacement config will only be useful to those that use Renovate. But still thinking about all possible options.

I'm not sure what happened, did you get hired by JetBrains? Or have you always worked there, some context would be nice... anyways, getting sidetracked :)

I joined JetBrains last spring, and have been working on bundling power-assert with Kotlin since the fall!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants