Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also test with drud/quicksprint #10

Open
mglaman opened this issue Mar 24, 2021 · 5 comments
Open

Also test with drud/quicksprint #10

mglaman opened this issue Mar 24, 2021 · 5 comments

Comments

@mglaman
Copy link
Member

mglaman commented Mar 24, 2021

See https://github.com/drud/quicksprint

@mradcliffe
Copy link

I think it should be okay to drop workshop/blob/main/.ddev/docker-compose.testing.yaml and the commands directory into sites/sprint-*/drupal/.config/ after users run start_sprint.sh?

@mglaman
Copy link
Member Author

mglaman commented Mar 24, 2021

That's now how I'd configure tests in a client project, though. This repo shows an example of how you'd setup tests in your own project environment.

Maybe I need to just make a PR to that project and document using it?

@mradcliffe
Copy link

mradcliffe commented Mar 24, 2021

It looks like the only changes would be to adopt the commands to Drupal core workflow/install rather than a Drupal core-recommended composer workflow since we're setup for core contribution.

Edit: 🙌

OK. 255  total assertions passed (3m 52s)
Done in 237.12s.

@mglaman
Copy link
Member Author

mglaman commented Mar 24, 2021

Ah, shoot. I totally forgot that this is using a Composer setup and would make it impossible to do core contribution, but only contrib. Thank you for bringing that up.

I'll have to make that clear. Because this is more of an example of how to configure things. Not a full environment to do those things. Like a reference. Not to replace drud/quicksprint.

@mradcliffe
Copy link

I'll have to make that clear. Because this is more of an example of how to configure things. Not a full environment to do those things. Like a reference. Not to replace drud/quicksprint.

That's how I read this. As an example that's adaptable for docker-based workflows lando, ddev, etc... core or custom projects so that more people can create tests for their contrib or personal projects and thus we level up and write more tests for core :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants