Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: IllegalStateException #1754

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: IllegalStateException #1754

wants to merge 4 commits into from

Conversation

mafanwei
Copy link

@mafanwei mafanwei commented Feb 1, 2024 •
edited by Gustl22

Description

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, refactor:,
    docs:, chore:, test:, ci: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

Fixes #1745.

#1745 #1738 #1726 #1703 etc.

@mafanwei mafanwei changed the title Fix IllegalStateException #1745 Fix IllegalStateException #1745 #1738 #1726 #1703 etc. Feb 5, 2024
@Gustl22 Gustl22 changed the title Fix IllegalStateException #1745 #1738 #1726 #1703 etc. Fix IllegalStateException etc. Feb 8, 2024
@Gustl22 Gustl22 changed the title Fix IllegalStateException etc. fix: IllegalStateException Feb 8, 2024
@Gustl22
Copy link
Collaborator

Gustl22 commented Feb 8, 2024

Hi there,
thanks for contributing!

I think it would be good to solve the problem for all platforms, not just Android.
Therefore you can add some tests, which fulfill your bug reproduction and test for the according exception:

audioplayers/packages/audioplayers/example/integration_test/platform_test.dart

Line 270 in 16e712c

testWidgets('#release ${td.source}', (tester) async {

We also already have a released flag in WrappedPlayer.kt which should be sufficient to solve this error in WrappedPlayer.kt rather than MediaPlayerPlayer.kt:

audioplayers/packages/audioplayers_android/android/src/main/kotlin/xyz/luan/audioplayers/player/WrappedPlayer.kt

Line 105 in 16e712c

var released = true

@Gustl22
Copy link
Collaborator

Gustl22 commented Feb 8, 2024

Tagging here some more relevant issue: #1708

@umar-hunch
Copy link

Can we please merge this? This error is really affecting our Production app with high amount of crashes

@Gustl22
Copy link
Collaborator

Gustl22 commented Mar 19, 2024

@umar-hunch you can always use dependecy overrides with the according fixes:
https://github.com/bluefireteam/audioplayers/blob/main/contributing.md#current-development

Also, I already reviewed that PR.
I'll try to get back to it next week (fixing myself), if the author isn't responding.

@Gustl22 Gustl22 mentioned this pull request Apr 12, 2024
Draft
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fatal Exception: java.lang.IllegalStateException
3 participants
@mafanwei @Gustl22 @umar-hunch