Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove enveloped_tx from TxEnv #995

Open
Rjected opened this issue Jan 19, 2024 · 1 comment
Open

Remove enveloped_tx from TxEnv #995

Rjected opened this issue Jan 19, 2024 · 1 comment
Labels
feature New feature or lib ability

Comments

@Rjected
Copy link
Collaborator

Rjected commented Jan 19, 2024

Related to #991

ref paradigmxyz/reth#6008 (comment)

Currently, the entire enveloped tx is used to calculate the optimism L1 tx cost, which is overkill given that the op-geth cost function acts on two fields:

// RollupCostData is a transaction structure that caches data for quickly computing the data
// availablility costs for the transaction.
type RollupCostData struct {
	zeroes, ones uint64
}

This should also be changed in the optimism version of the tx env.

@rakita
Copy link
Member

rakita commented Jan 19, 2024

Just to link the issue, the Generic Tx trait is a solution for this: #916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or lib ability
Projects
None yet
Development

No branches or pull requests

2 participants