Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include cargo lints #887

Open
rakita opened this issue Nov 29, 2023 · 1 comment
Open

Include cargo lints #887

rakita opened this issue Nov 29, 2023 · 1 comment
Labels
good first issue Good for newcomers refactor Refactor of the code

Comments

@rakita
Copy link
Member

rakita commented Nov 29, 2023

On workspace level: https://blog.rust-lang.org/2023/11/16/Rust-1.74.0.html#lint-configuration-through-cargo

atm we still want to be compatible with 1.66 rust version as llvm 17 introduced invalid instruction: llvm/llvm-project#69408 that is troubling for some projects. When rust bumps to new llvm this could go in.

Bug fix is included in 17.0.6: llvm/llvm-project@llvmorg-17.0.5...llvmorg-17.0.6
@refcell refcell mentioned this issue Dec 2, 2023
Closed
@rakita rakita added the refactor Refactor of the code label Dec 25, 2023
@rakita rakita mentioned this issue Jan 15, 2024
Merged
@rakita
Copy link
Member Author

rakita commented Mar 2, 2024

llvm got a fixed in v1.75.0
https://github.com/rust-lang/rust/blob/1.75.0/.gitmodules

Bug fix PR in rust is here: rust-lang/rust#118936

@rakita rakita added the good first issue Good for newcomers label Mar 6, 2024
@rakita rakita mentioned this issue Mar 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers refactor Refactor of the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(crates): Package Manifest Lint Reporting Levels refcell/revm
1 participant
@rakita