Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move DB inside JournaledState as it is only component that uses it #1159

Open
rakita opened this issue Mar 6, 2024 · 2 comments
Open

Move DB inside JournaledState as it is only component that uses it #1159

rakita opened this issue Mar 6, 2024 · 2 comments
Labels
question refactor Refactor of the code

Comments

@rakita
Copy link
Member

rakita commented Mar 6, 2024

DB generic is currently in EvmContext and should be easy to move to JournaledState as it is only used by it.

Make a db() util fn on Context
@rakita rakita added good first issue Good for newcomers refactor Refactor of the code labels Mar 6, 2024
@mattsse
Copy link
Collaborator

mattsse commented Mar 6, 2024

this will break a bunch of foundry code because we rely on journalstate as a standalone thing for multiforking/snapshotting

@rakita
Copy link
Member Author

rakita commented Mar 6, 2024

this will break a bunch of foundry code because we rely on journalstate as a standalone thing for multiforking/snapshotting

Didn't know that. Could something like InitJournalState structure work here?

@rakita rakita added question and removed good first issue Good for newcomers labels Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question refactor Refactor of the code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rakita @mattsse