Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename coinbase to beneficiary in BlockEnv #1012

Open
tcoratger opened this issue Jan 25, 2024 · 6 comments
Open

Rename coinbase to beneficiary in BlockEnv #1012

tcoratger opened this issue Jan 25, 2024 · 6 comments
Labels
refactor Refactor of the code

Comments

@tcoratger
Copy link
Contributor

Issue Description

Currently, in the BlockEnv of the primitives crate, the recipient of all gas spent within a block is referred to as coinbase:

pub coinbase: Address,

To align with the latest yellow specifications and adhere to reth node standards, I propose renaming this field to beneficiary.

Suggested Changes

  • Rename the coinbase field to beneficiary in the BlockEnv struct.

Context

The suggested change is in line with the evolving standards in the Ethereum ecosystem, ensuring consistency and compliance with the latest specifications. This modification will improve clarity and maintain compatibility with the broader Ethereum development community.

@rakita rakita added the refactor Refactor of the code label Jan 25, 2024
@rakita
Copy link
Member

rakita commented Jan 25, 2024

I would not break it rn but after the next release. And change is reasonable.

Related to this: #916

@PanGan21
Copy link

PanGan21 commented Feb 3, 2024

Hey guys, sorry I saw the comment to hold on a bit late 😅
If it is still not required let me know and I will close the pr

@rakita
Copy link
Member

rakita commented Feb 4, 2024

Hey guys, sorry I saw the comment to hold on a bit late 😅 If it is still not required let me know and I will close the pr

Lets close it, otherwise it will stay open for a few months, I apologize for the confusion

@developeruche
Copy link
Contributor

Added this to this pull request #1209

@rakita
Copy link
Member

rakita commented Mar 19, 2024

Added this to this pull request #1209

Please revert those, there is no need to break it right now.

@developeruche
Copy link
Contributor

Reverted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor of the code
Projects
None yet
Development

No branches or pull requests

4 participants