Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devise a test harness for testing performance #61

Open
godlygeek opened this issue Apr 23, 2023 · 5 comments
Open

Devise a test harness for testing performance #61

godlygeek opened this issue Apr 23, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@godlygeek
Copy link
Contributor

We know there's low hanging fruit available for optimizing PyStack, but we currently have no good way to benchmark our performance and quantify any improvements. Design some sort of a test harness that can be used for measuring the performance impact of our changes, possibly using https://asv.readthedocs.io/en/stable/

@godlygeek godlygeek added the enhancement New feature or request label Apr 23, 2023
@Helithumper
Copy link
Contributor

I'll look into this today and tomorrow.

@Helithumper
Copy link
Contributor

Wasn't able to look into this. Feel free to unsassign

@ms2892
Copy link

ms2892 commented Jan 13, 2024

How is the impact of the performance impact of changes defined? Is it meant to be a time and space benchmark against a predefined use?
Also is it meant to be integrated into a github workflow or is it meant to be a separate module of its own?

@sarahmonod
Copy link
Contributor

How is the impact of the performance impact of changes defined? Is it meant to be a time and space benchmark against a predefined use? Also is it meant to be integrated into a github workflow or is it meant to be a separate module of its own?

My understanding is that we want to have something similar to the CodeCov integration, where we can easily tell, for any given PR, if a number of predefined measurements differ when measured on main vs on the PR branch. This way, we can both have a better understanding on the current time and space performance of PyStack, and be aware if we are significantly changing them with a PR.

Any PR whose goal is to change performance would be close to meaningless without a way of measuring the difference.

@ms2892
Copy link

ms2892 commented Jan 25, 2024

How is the impact of the performance impact of changes defined? Is it meant to be a time and space benchmark against a predefined use? Also is it meant to be integrated into a github workflow or is it meant to be a separate module of its own?

My understanding is that we want to have something similar to the CodeCov integration, where we can easily tell, for any given PR, if a number of predefined measurements differ when measured on main vs on the PR branch. This way, we can both have a better understanding on the current time and space performance of PyStack, and be aware if we are significantly changing them with a PR.

Any PR whose goal is to change performance would be close to meaningless without a way of measuring the difference.

Hi Gus,

I implemented it in the PR #165. Please have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants