Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Aave to contract parser #93

Open
3 tasks done
askeluv opened this issue May 15, 2020 · 8 comments · Fixed by #94
Open
3 tasks done

Add Aave to contract parser #93

askeluv opened this issue May 15, 2020 · 8 comments · Fixed by #94

Comments

@askeluv
Copy link
Member

askeluv commented May 15, 2020

Context

We add "table definition" for contract events so that we can regularly parse these events from Ethereum logs. One benefit of this is that the events become available in public BigQuery tables, under the blockchain-etl project.

For more details on this, please read How to get any Ethereum smart contract into BigQuery.

In this ticket we are looking to add datasets for Aave.

Proposed solution

Add table definition files for Aave by following the checklist below.

Checklist

  1. 1. Identify all smart contracts for Aave
  2. 2. Generate table definition files for all the contracts in your list using this Contract Parser
  3. 3. Create Pull Request containing all the table definition files

Please note

  • For step 1 you could use a site like DappRadar or ETH Gas Station to find the contracts.
  • For step 2 that you may have to manually edit the table definition files if there are multiple contracts with the same name. You can add e.g. _v2 so contract becomes contract_v2.

Before applying for this bounty, please list the contracts identified in step 1, and confirm you've understood the process.

It may be helpful to look at past PRs that are labeled contract parsing.

@sebastiantf
Copy link
Contributor

Would love to work on this

@askeluv
Copy link
Member Author

askeluv commented May 15, 2020

Cool @sebastiantf - I'm waiting for the Gitcoin transaction to go through. There will be a $20 USDC bounty on this.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 20.0 USDC (20.02 USD @ $1.0/USDC) attached to it.

@gitcoinbot
Copy link

gitcoinbot commented May 15, 2020

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 1 month from now.
Please review their action plans below:

1) sebastiantf has been approved to start work.

Easy task. Can turn around fast

Learn more on the Gitcoin Issue Details page.

@sebastiantf
Copy link
Contributor

sebastiantf commented May 16, 2020

Hey I'm seeing the same contract name AToken in about 6+ contracts with the same events. So I'm renaming them with suffixes like _v2.json, _v3.json, ... _v7.json. Is that normal?

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 20.0 USDC (20.01 USD @ $1.0/USDC) has been submitted by:

  1. @sebastiantf

@askeluv please take a look at the submitted work:


@sebastiantf sebastiantf mentioned this issue May 21, 2020
@gitcoinbot
Copy link

⚡️ A tip worth 20.00000 USDC (20.02 USD @ $1.0/USDC) has been granted to @sebastiantf for this issue from @askeluv. ⚡️

Nice work @sebastiantf! Your tip has automatically been deposited in the ETH address we have on file.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 20.0 USDC (20.02 USD @ $1.0/USDC) attached to this issue has been approved & issued to @sebastiantf.

Additional Tips for this Bounty:

  • askeluv tipped 20.0000 USDC worth 20.02 USD to sebastiantf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants