Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chart] Set autoscaling.minReplica=2 by default #66

Open
AndersBennedsgaard opened this issue Feb 13, 2024 · 1 comment
Open

[chart] Set autoscaling.minReplica=2 by default #66

AndersBennedsgaard opened this issue Feb 13, 2024 · 1 comment

Comments

@AndersBennedsgaard
Copy link

By default, autoscaling.enabled=true, autoscaling.minReplica=1, podDisruptionBudget.enabled=true, and podDisruptionBudget.minAvailable=1.

This means that since (by default) the HPA allows autoscaling to 1 replica, you might get errors when patching nodes, since kubectl drain will try to remove the single Cortex Tenant pod, which the PDB doesn't allow.

The workaround is simple; set autoscaling.minReplica=2 or disable the PDB.
However, it would be nice if the chart is possible to deploy to a cluster with as few changes as possible, so I would like the chart to have autoscaling.minReplica=2 by default. What do you think of this?

@blind-oracle
Copy link
Owner

Sorry for late answer.
I have no problems with that, but since I don't use k8s at all, I have no strong opinion. If you want to change that - please make a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants