Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address bar border with Firefox 126 #889

Open
2 of 9 tasks
shibotto opened this issue May 14, 2024 · 3 comments
Open
2 of 9 tasks

Address bar border with Firefox 126 #889

shibotto opened this issue May 14, 2024 · 3 comments
Labels
Browser::Upstream Changes or bugs from Firefox Component::Tabbar Tab or tabbar Env::Linux Issues on Linux Issue::Bug Something isn't working

Comments

@shibotto
Copy link

Describe the bug

The active tab no longer draws on top of the address bar.

Expected behavior

The address bar border to be hidden under the active tab.

Screenshots

Firefox 125.0.3
Schermata da 2024-05-14 17-21-11

Firefox 126
Schermata da 2024-05-14 17-21-50

OS

Linux

OS - Others

No response

Firefox Version

126

Distribution

Theme

Theme - More Info

Graybird

user.js setup

I don't know where that is, sorry. I just did ./install.sh on a live environment.

Additional context

No response

@shibotto shibotto added the Issue::Bug Something isn't working label May 14, 2024
@black7375 black7375 added Env::Linux Issues on Linux Component::Tabbar Tab or tabbar Browser::Upstream Changes or bugs from Firefox labels May 15, 2024
@black7375
Copy link
Owner

This is an issue that can occur with some themes on Linux.
border-top was a problem, which I replaced with box-shadow.

@shibotto
Copy link
Author

shibotto commented May 25, 2024

That's a smart idea, but the -0,01px box-shadow is probably the same as no shadow at all. Setting it to -1px however makes it look just like before on every GTK+ theme I tried:

Schermata da 2024-05-25 09-50-52
Schermata da 2024-05-25 09-51-02
Schermata da 2024-05-25 09-51-27
Schermata da 2024-05-25 09-52-03
Schermata da 2024-05-25 09-52-13

But of course that doesn't work as well for Firefox own themes and that 1px border-like shadow becomes really an eyesore:

Schermata da 2024-05-25 09-58-28
Schermata da 2024-05-25 09-57-17

If it's not possible to set it only when using the system theme, then probably your current solution is the best one.

@black7375
Copy link
Owner

Of course, bolding is only possible in Linux system themes.
Thanks to your feedback.

Hou-Rui pushed a commit to Hou-Rui/lepton-oneline that referenced this issue May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser::Upstream Changes or bugs from Firefox Component::Tabbar Tab or tabbar Env::Linux Issues on Linux Issue::Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants