Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test cases to have a common test case logic for all diagram formats #266

Closed
bkryza opened this issue May 1, 2024 · 0 comments · Fixed by #272
Closed

Refactor test cases to have a common test case logic for all diagram formats #266

bkryza opened this issue May 1, 2024 · 0 comments · Fixed by #272
Labels
enhancement New feature or request
Milestone

Comments

@bkryza
Copy link
Owner

bkryza commented May 1, 2024

Currently, test cases have separate test sections for each diagram output format (PlantUML, MermaidJS and JSON).

This is intractable if we want to add more output formats - there should be the same test code for all output formats, with only custom additional tests for specific format and test cases.

@bkryza bkryza added the enhancement New feature or request label May 1, 2024
@bkryza bkryza added this to the 0.5.3 milestone May 1, 2024
@bkryza bkryza changed the title Refactor test cases to have a common test case logic for all diagram format Refactor test cases to have a common test case logic for all diagram formats May 1, 2024
bkryza added a commit that referenced this issue May 14, 2024
@bkryza bkryza mentioned this issue May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant