Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow moderators to move around any other person #70

Open
djay opened this issue Sep 26, 2018 · 6 comments
Open

Allow moderators to move around any other person #70

djay opened this issue Sep 26, 2018 · 6 comments

Comments

@djay
Copy link
Contributor

djay commented Sep 26, 2018

It would be very useful as people are shy to place themselves on the map. The admins can sort people into groups ahead of time.

@waf
Copy link
Member

waf commented Sep 26, 2018

This should already be implemented as part of #9 . As long as you're logged in and you either have "MEMBER" or "OWNER" role, you can place anybody.

@djay
Copy link
Contributor Author

djay commented Sep 26, 2018

I can't move people around. I think I'm "Maintainer"

@waf
Copy link
Member

waf commented Oct 6, 2018

@djay according to the api you're coming back as a User for this repo.

Is it possible you have to join this repo specifically?

@ches
Copy link
Member

ches commented Apr 25, 2019

Doesn't work for me either, I tried adding the "Organizers" team explicitly to this repo, with Admin level, and then also added myself individually to this repo as an explicit collaborator. Neither made a difference.

I didn't start debugging with API responses yet, but there might still be a bug with implementation, and/or we can maybe use a way to roles from the organization level for this case.

@waf
Copy link
Member

waf commented Apr 25, 2019

Thanks @ches for looking into this. Now, I can no longer move avatars either. I've verified that my user is also coming back "type: User" now.

It's unclear to me when "type" is anything other than User now. I can't find any change announcements from GitHub either. Possibly we need to use a different API to get organization membership.

@waf
Copy link
Member

waf commented Apr 25, 2019

If we can't rely on "user.type" to have the correct value, we could potentially start using "comment.author_association" in that same API response. I'd prefer to use this property, if possible, so we don't need to introduce the overhead of another API request/response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants