Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple Login forward aliases should not be random #3189

Open
1 task
Teskann opened this issue Apr 24, 2024 · 1 comment
Open
1 task

Simple Login forward aliases should not be random #3189

Teskann opened this issue Apr 24, 2024 · 1 comment
Labels

Comments

@Teskann
Copy link

Teskann commented Apr 24, 2024

Steps To Reproduce

  1. Create a new entry in Bitwarden
  2. Go into username generator
  3. Select forwarded email alias
  4. Chose SimpleLogin provider (add your API key)
  5. Generate the alias

Expected Result

I expect the alias to contain the domain name of the website for which I created the alias (this is how behaves the web browser extension).

For instance, let's assume I follow the steps above from the web extension and create an entry from Amazon website. Here is the kind of result I can get:
image
You can see "amazon" in the email adress.

I would expect the same behavior on mobile app.

Actual Result

If I do this from the Android app, I get a complete random alias, like spider_shocking.abcde@simplelogin.com. This makes it harder to track which adress is linked with which website.

Screenshots or Videos

No response

Additional Context

It seems in src/Core/Services/EmailForwarders/SimpleLoginForwarder.cs, you use the Simple Login API to generate a random alias.

You could instead use this POST method and pass the domain name to the alias_prefix parameter: https://github.com/simple-login/app/blob/master/docs/api.md#post-apiv3aliascustomnew

Thanks in advance,
Cheers,

Operating System

Android

Operating System Version

No response

Device

No response

Build Version

2024.4.0 (10172)

Beta

  • Using a pre-release version of the application.
@Teskann Teskann added the bug label Apr 24, 2024
@cbbit
Copy link

cbbit commented Apr 29, 2024

Hi there,

Thank you for your report!

I was able to reproduce this issue, and I have flagged this to our engineering team.

If you wish to add any further information/screenshots/recordings etc., please feel free to do so at any time - our engineering team will be happy to review these.

Thanks once again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants