Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Waterfox Android support from FD399097 #2886

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add Waterfox Android support from FD399097 #2886

wants to merge 1 commit into from

Conversation

atjbramley
Copy link

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This PR is meant to add complete autofill support for the Waterfox Android browser.

Waterfox is getting ready for GR on Android (https://www.waterfox.net/docs/releases/G6.0b5/ )

Code changes

  • src/Android/Accessibility/AccessibilityHelpers.cs: Added a new Browser object to the SupportedBrowsers dictionary to add support for Waterfox.
  • src/Android/Autofill/AutofillHelpers.cs: Added a new item to the CompatBrowsers hashset to add support for Waterfox.
  • src/Android/Resources/xml/autofillservice.xml: Added a new compatibility-package object to add support for Waterfox.

@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Details – f93e3a44-b916-43c5-bbeb-57d8340974ab

No New Or Fixed Issues Found

@djsmith85 djsmith85 requested a review from a team December 4, 2023 18:31
@adriy-be
Copy link

adriy-be commented Feb 8, 2024

Hi, I'm using waterfox on android.
I have compare to #2640, and it's seem to be fine.

@sushix2000 sushix2000 mentioned this pull request Mar 23, 2024
Open
1 task
@djsmith85 djsmith85 linked an issue Mar 25, 2024 that may be closed by this pull request
Bitwarden App doesn't recognize Android version of Waterfox as a browser when matching Auto-Fill #3109
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bitwarden App doesn't recognize Android version of Waterfox as a browser when matching Auto-Fill
3 participants
@atjbramley @bitwarden-bot @adriy-be